This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Create trait for NPoS election algorithms #9664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kiz-election-trait
… kiz-election-trait
emostov
commented
Aug 31, 2021
emostov
added
A3-in_progress
emostov
added
A0-please_review
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
kianenigma
reviewed
Sep 1, 2021
…bstrate into kiz-election-trait
emostov
commented
Sep 7, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
chevdor
approved these changes
Sep 8, 2021
|
bot merge |
|
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
|
bot merge |
|
Error: Approval criteria was not satisfied. The following errors might have affected the outcome of this attempt:
Merge failed. Check out the criteria for merge. |
bkchr
approved these changes
Sep 9, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a common trait that all NPoS election algorithms can implement. This is particularly helpful when it is desired for the election solving approach to be configurable (e.g an election result mining binary).
polkadot companion: paritytech/polkadot#3752
closes: #9666